Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gradle Checkstyle #1444

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

ThomasPerkins1123
Copy link
Contributor

The previous attempt to add a checkstyle to gradle failed, but after more thorough testing this should work.
I also made the paths in the suppression file OS agnostic as previously if you ran ./gradlew build followed by mvn install you would get a checkstyle failure on windows as it would not pick up on the path for the build suppressions.

@dsyer
Copy link
Member

dsyer commented Feb 9, 2024

You had to duplicate the suppressions XML file? Seems like a dangerous move (not that it changes very often, but it will definitely break next time someone updates one of them and didn't know about the other).

@ThomasPerkins1123
Copy link
Contributor Author

ThomasPerkins1123 commented Feb 9, 2024

You had to duplicate the suppressions XML file? Seems like a dangerous move (not that it changes very often, but it will definitely break next time someone updates one of them and didn't know about the other).

I agree, I was trying to avoid this but was struggling to make the nohttp check use this config.
I will have another look and see if I can get that to work

@dsyer dsyer merged commit a2f1ad5 into spring-projects:main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants